-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add variant/module for cooling technologies in tools.costs
#222
Conversation
720ccd7
to
8662c7c
Compare
159089e
to
55e2446
Compare
670b91e
to
c879f8c
Compare
55e2446
to
e2baa3d
Compare
Thanks @measrainsey for advancing this work! just a note for the general module that could maybe improved with a fix or just notified to developers: One limitation of the fix cost generator is that is does not take into account of the technology lifetime in the vintage-activity years. This way the output dataframe is way larger than actually needed and might take up space. (for example with cooling technologies with 30 years lifetime) the fix_cost df would be five time smaller than the actual one. I understand that including the lifetime in the process would require adding the information in the initial data, and maybe we don't want it. |
e4748dd
to
0dd543d
Compare
b4f5da4
to
0f6eb06
Compare
0dd543d
to
0e382a7
Compare
d16662e
to
49c8f5f
Compare
0e382a7
to
8611cbd
Compare
49c8f5f
to
d7d6f96
Compare
c445299
to
441faeb
Compare
Sorry I forgot to respond to this comment/review here as Adriano and I had a side conversation about this topic! But I'll put my thoughts here anyways to preserve them on this platform. Additionally, this issue of lifetime was also brought to my attention by Oliver, so I might have to address this at some point. While my initial thoughts/feelings was to keep technology lifetime outside of this tool so that the tool can remain agnostic to so many inputs/parameters (as perhaps technology lifetimes can vary across scenarios, hypothetically) and as lean as possible, I can see that keeping costs projection for a technology beyond its lifetime can (a) cause confusion and (b) lead to very large output dataframes, like Adriano mentioned. It seems the best way to make sure lifetimes and vintages are accounted for would be to have the tool call upon the |
d7d6f96
to
c996a88
Compare
441faeb
to
f02caf3
Compare
c996a88
to
d40e3c8
Compare
f02caf3
to
6883189
Compare
87787a1
to
2ad864b
Compare
cc804c7
to
d70f910
Compare
2ad864b
to
ecb3497
Compare
Thanks @khaeru for your suggestion. I have created an issue #237 to track progress on this, and for the time being, I have added a note in the documentation: message-ix-models/doc/api/tools-costs.rst Lines 151 to 154 in 70db1b2
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. @glatterf42 was there anything else you were waiting to see here, or can I merge?
Nope, good from my side :) |
70db1b2
to
2468c2d
Compare
Hi all, thanks for approving the PR! Just a quick note that this branch is based off of the branch in #227, so that PR should probably be approved and merged before this one, I presume? |
You could also merge this PR into the branch it originated from. This would increase the size of the other PR, but we could focus on the changes not already reviewed. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #222 +/- ##
=======================================
- Coverage 75.5% 75.5% -0.1%
=======================================
Files 203 203
Lines 15503 15503
=======================================
- Hits 11707 11706 -1
- Misses 3796 3797 +1
|
Add a variant/module to project costs for cooling technologies
This PR adds a new module within
tools.costs
calledcooling
. @adrivinca has provided input data for these technologies -- these technologies are currently all mapped to a technology in theenergy
module (based on the assumption that these cooling technologies are sort of addons that follow the same regional differentiation as their non-addon counterpart). However, the cooling technologies have their own base year reference region costs.This PR's branch is derived from the
costs/reduction-year
branch, which has its own PR #227. Once that one is merged, I will rebase.How to review
For @adrivinca: Verify if the implementation is correct and if the outputs make sense.
For @khaeru and/or @glatterf42 : Read the diff and note that the CI checks all pass.
PR checklist