Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The gas grid newly defined variables have been added. #8

Merged
merged 6 commits into from
Jan 20, 2025

Conversation

enokandi
Copy link
Contributor

The newly defined gas grid variables.

Copy link
Member

@danielhuppmann danielhuppmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR mixes two types of variables - the technical parameters that are fairly straightforward, plus other variables which are problematic for a number of reasons, like shares, nominal consumption, statistical descriptions...

I suggest to remove all Share and Final Energy variables from this PR, review, merge, then start another PR to discuss these items.

@@ -0,0 +1,96 @@
- Capacity|Natural Gas|Regasifier:
description: Regasifier upperbound capacity
unit: [GW]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to use lists here for the units - please fix in this entire file.

Suggested change
unit: [GW]
unit: GW

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Daniel. Done!

Copy link
Member

@danielhuppmann danielhuppmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments and suggestions inline

definitions/variable/grids infrastructure/gas_grid.yaml Outdated Show resolved Hide resolved
- Extraction Rate|Gas|Storage|Depleted Field:
description: Depleted Field storage Extraction Rate
unit: GW
- Network|Gas|Natural Gas|Capacity:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming that methane and hydrogen cannot use the same networks, I suggest to simplify to

  • Network|Natural Gas|Capacity
  • Network|Hydrogen|Capacity

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed all the terms 'Network|Gas|Natural Gas' and 'Network|Gas|Hydrogen' into 'Network|Natural Gas' and 'Network|Hydrogen'.

definitions/variable/grids infrastructure/gas_grid.yaml Outdated Show resolved Hide resolved
definitions/variable/grids infrastructure/gas_grid.yaml Outdated Show resolved Hide resolved
definitions/variable/grids infrastructure/gas_grid.yaml Outdated Show resolved Hide resolved
@enokandi enokandi force-pushed the gas_variables branch 2 times, most recently from b6037ed to 76387cf Compare January 19, 2025 20:24
Copy link
Member

@danielhuppmann danielhuppmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few suggestions inline to make the descriptions easer to understand, please implement for all variables

definitions/variable/grids infrastructure/gas_grid.yaml Outdated Show resolved Hide resolved
@@ -0,0 +1,51 @@
- Capacity|Natural Gas|Regasifier:
description: Regasifier upperbound capacity
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Installed (available) capacity for regasification of methane ('natural gas')

description: Regasifier upperbound capacity
unit: GW
- Capacity|Natural Gas|Storage|Aquifer:
description: Aquifer storage capacity
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Available capacity for storage of methane ('natural gas') in aquifers

description: Depleted Field storage capacity
unit: GWh
- Injection Rate|Natural Gas|Storage|Aquifer:
description: Aquifer storage Injection Rate
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
description: Aquifer storage Injection Rate
description: Maximum injection rate of methane ('natural gas') into aquifers

description: Depleted Field storage Extraction Rate
unit: GW
- Network|Natural Gas|Capacity:
description: Capacity of the pipeline
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
description: Capacity of the pipeline
description: Upper bound of natural gas pipeline capacity

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Daniel for the comments. It's done now.

Copy link
Member

@danielhuppmann danielhuppmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@danielhuppmann danielhuppmann merged commit dc74557 into iiasa:main Jan 20, 2025
2 checks passed
@enokandi enokandi deleted the gas_variables branch January 21, 2025 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants