-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The gas grid newly defined variables have been added. #8
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR mixes two types of variables - the technical parameters that are fairly straightforward, plus other variables which are problematic for a number of reasons, like shares, nominal consumption, statistical descriptions...
I suggest to remove all Share and Final Energy variables from this PR, review, merge, then start another PR to discuss these items.
@@ -0,0 +1,96 @@ | |||
- Capacity|Natural Gas|Regasifier: | |||
description: Regasifier upperbound capacity | |||
unit: [GW] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need to use lists here for the units - please fix in this entire file.
unit: [GW] | |
unit: GW |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Daniel. Done!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few comments and suggestions inline
- Extraction Rate|Gas|Storage|Depleted Field: | ||
description: Depleted Field storage Extraction Rate | ||
unit: GW | ||
- Network|Gas|Natural Gas|Capacity: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Assuming that methane and hydrogen cannot use the same networks, I suggest to simplify to
- Network|Natural Gas|Capacity
- Network|Hydrogen|Capacity
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I changed all the terms 'Network|Gas|Natural Gas' and 'Network|Gas|Hydrogen' into 'Network|Natural Gas' and 'Network|Hydrogen'.
b6037ed
to
76387cf
Compare
…s changed to Natural gas
76387cf
to
776ef28
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few suggestions inline to make the descriptions easer to understand, please implement for all variables
@@ -0,0 +1,51 @@ | |||
- Capacity|Natural Gas|Regasifier: | |||
description: Regasifier upperbound capacity |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Installed (available) capacity for regasification of methane ('natural gas')
description: Regasifier upperbound capacity | ||
unit: GW | ||
- Capacity|Natural Gas|Storage|Aquifer: | ||
description: Aquifer storage capacity |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Available capacity for storage of methane ('natural gas') in aquifers
description: Depleted Field storage capacity | ||
unit: GWh | ||
- Injection Rate|Natural Gas|Storage|Aquifer: | ||
description: Aquifer storage Injection Rate |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
description: Aquifer storage Injection Rate | |
description: Maximum injection rate of methane ('natural gas') into aquifers |
description: Depleted Field storage Extraction Rate | ||
unit: GW | ||
- Network|Natural Gas|Capacity: | ||
description: Capacity of the pipeline |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
description: Capacity of the pipeline | |
description: Upper bound of natural gas pipeline capacity |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Daniel for the comments. It's done now.
2a8394a
to
5a06685
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
The newly defined gas grid variables.