Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding new items to tag_electricity-source.yaml file #10

Merged
merged 3 commits into from
Jan 27, 2025

Conversation

enokandi
Copy link
Contributor

Oil was added as a new source.
Internal Combustion was added as another technology, but only for oil.
Pumped Storage was added.

…t types related to oil, Internal combustion as a newly defined technology only for oil, Pumped storage hydro
@danielhuppmann
Copy link
Member

Sorry for being a pain, but it seems that your text-editor changing the indentation, so that all lines are changed and it is difficult to see the new items in the "Files Changed" tab - could you please change to use 2 whitespaces for indentation instead of 4? Also important for consistency across files...

@enokandi
Copy link
Contributor Author

Sorry for being a pain, but it seems that your text-editor changing the indentation, so that all lines are changed and it is difficult to see the new items in the "Files Changed" tab - could you please change to use 2 whitespaces for indentation instead of 4? Also important for consistency across files...

Hi Daniel. You are right. I fixed it.

Copy link
Member

@danielhuppmann danielhuppmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @enokandi - I took the liberty of fixing one typo directly in your branch, now good to be merged.

@danielhuppmann danielhuppmann merged commit 2353b73 into iiasa:main Jan 27, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants