Popover - TrackViewport - discard items properly

igvteam · Dec 7, 2023 · a2aba67 · a2aba67
1 parent cc71edb
commit a2aba67
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 4 deletions.
diff --git a/js/trackViewport.js b/js/trackViewport.js
@@ -869,6 +869,22 @@ class TrackViewport extends Viewport {
         return content
     }
 
+    dispose() {
+
+        if (this.popover) {
+            this.popover.dispose()
+        }
+
+        if (this.popoverList) {
+            for (let i = 0; i < this.popoverList.length; i++ ) {
+                this.popoverList[ i ].dispose()
+            }
+
+            this.popoverList = undefined
+        }
+
+        super.dispose()
+    }
 
 }
 

diff --git a/js/viewport.js b/js/viewport.js
@@ -192,10 +192,6 @@ class Viewport {
      */
     dispose() {
 
-        if (this.popover) {
-            this.popover.dispose()
-        }
-
         this.$viewport.get(0).remove()
 
         // Null out all properties -- this should not be neccessary, but just in case there is a