fixes #357: No longer show NPE on admin console after user session ex…

…pired

The NPE shown was an artifact of the page being processed without authentication in place. This should be prevented by the AuthCheckFilter.

Sadly, a naming collision prevents the AuthCheckFilter to operate on the Monitoring Service admin console pages.

This commit prevents the naming collision, by renaming the endpoint on which the public API for logs is exposed (from 'monitoring' to 'logs').

changelog.html

@@ -44,6 +44,11 @@ <h1>
 Monitoring Plugin Changelog
 </h1>
 
+<p><b>2.4.2</b> -- (tbd)</p>
+<ul>
+    <li>[<a href='https://github.com/igniterealtime/openfire-monitoring-plugin/issues/357'>Issue #357</a>] - Fixes: Error on admin console after user session expired.</li>
+</ul>
+
 <p><b>2.4.1</b> -- December 6, 2022</p>
 <ul>
     <li>[<a href='https://github.com/igniterealtime/openfire-monitoring-plugin/issues/246'>Issue #246</a>] - Fixes: Clicking graph no longer opens bigger graph on admin console</li>

plugin.xml

@@ -6,7 +6,7 @@
     <description>Monitors conversations and statistics of the server.</description>
     <author>Ignite Realtime</author>
     <version>${project.version}</version>
-    <date>2022-12-06</date>
+    <date>2023-03-15</date>
     <minServerVersion>4.7.0</minServerVersion>
     <minJavaVersion>1.8</minJavaVersion>
     <databaseKey>monitoring</databaseKey>

src/java/org/jivesoftware/openfire/plugin/MonitoringPlugin.java

@@ -69,7 +69,7 @@ public class MonitoringPlugin implements Plugin, PluginListener
     /**
      * The context root of the URL under which the public web endpoints are exposed.
      */
-    public static final String CONTEXT_ROOT = "monitoring";
+    public static final String CONTEXT_ROOT = "logs";
 
     private static final SystemProperty<Boolean> MOCK_VIEWER_ENABLED = SystemProperty.Builder.ofType( Boolean.class )
        .setKey("stats.mock.viewer" )