OF-2397: Do not process subscription requests for shared contacts #2624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a contact is a contact by virtue of being in a shared group, the presence subscription between the roster owner and this contact is deemed to be static. Presence subscriptions sent by the client of either party should not affect this status.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a contact is a contact by virtue of being in a shared group, the presence subscription between the roster owner and this contact is deemed to be static.
Presence subscriptions sent by the client of either party should not affect this status.
I've not tested this change at all. I'm not at all sure if it is complete (does it cover all applicable cases? does it also process messages sent by both the 'roster owner' as well as the contact itself)? I also worry about potential side-effects.
I'm creating this PR mostly as a means of getting started. Hopefully someone can pitch in and help test, and possibly improve this change.