Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OF-2892 Available Plugins page: redesign to make Documentation easier to see #2541

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

stokito
Copy link
Contributor

@stokito stokito commented Sep 22, 2024

The Plugins and Available plugins pages have two icons for documentation (README) and changelog.

The icons are very small and placed together that makes it difficult to understand them.

The icons are only 16px and the only way to understand is to put a cursor over them to see a title. This wouldn't be possible to to from a mobile at all (minor issue).

As a solution we can switch to a table where each cell can have a few lines.

I moved the changelog icon into the Version column as a an additional row. The re

Similarly the Documentation link moved into the Description column, and the Description merged into the Plugin Name.

available plugins

@stokito stokito force-pushed the OF-1823_plugins branch 2 times, most recently from 3b217ed to 5917a86 Compare October 18, 2024 13:14
@stokito stokito changed the title OF-1823 admin console plugins pages OF-2892 Available Plugins page: redesign to make Documentation easier to see Oct 18, 2024
@stokito stokito marked this pull request as ready for review October 18, 2024 13:17
@Fishbowler
Copy link
Member

I've not tested this (yet) but this looks to be an awesome change!
Those icons have bothered me massively. I'd love to get this into vNext.

@Fishbowler
Copy link
Member

I've run this on top of main. Dates render, docs and changelog links work.

There's one rendering bug when installing a plugin.

Before:
image

After:
image

The columns all narrow to display the ✔️ for a few seconds, then returns to the before state.

@Fishbowler
Copy link
Member

Pushed the rebase.

@stokito
Copy link
Contributor Author

stokito commented Dec 15, 2024

I fixed the bug with an additional column in the 1e632dc

Also I rebased on top of main branch. So the PR can be merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants