Script updating archive at 2023-10-24T00:35:52Z. [ci skip]

ietf-wg-jose · Oct 24, 2023 · 96971bd · 96971bd
1 parent 66158fa
commit 96971bd
Showing 1 changed file with 69 additions and 6 deletions.
diff --git a/archive.json b/archive.json
@@ -1,6 +1,6 @@
 {
   "magic": "E!vIA5L86J2I",
-  "timestamp": "2023-10-22T00:38:22.128849+00:00",
+  "timestamp": "2023-10-24T00:35:49.681004+00:00",
   "repo": "json-web-proofs/json-web-proofs",
   "labels": [
     {
@@ -5791,12 +5791,12 @@
       "url": "https://github.com/json-web-proofs/json-web-proofs/pull/84",
       "state": "CLOSED",
       "author": "AlbertoSvg",
-      "authorAssociation": "NONE",
+      "authorAssociation": "CONTRIBUTOR",
       "assignees": [],
       "labels": [],
       "body": "Hello Everyone,\r\n\r\nI submitted this pull request to address what I believe is an error in the [BBS algorithm example](https://datatracker.ietf.org/doc/html/draft-ietf-jose-json-proof-algorithms#name-example-2) in the JPA draft. In the provided presented JWP representation, there is only one \"protected\" header referring to the issued protected header. However, according to section [6.2.6](https://datatracker.ietf.org/doc/html/draft-ietf-jose-json-proof-algorithms#section-6.2.6) of this draft and section [4.2.1](https://datatracker.ietf.org/doc/html/draft-ietf-jose-json-web-proof#section-4.2.1) of the JWP draft, there should also be a presentation protected header containing the nonce used for the generation and verification of the proof used to present the JWP to a Verifier.\r\n\r\nAdditionally, I corrected the encoding of the protected headers during \"compact serialization.\" The header value present in the JSON representation had already undergone the UTF-8 and base64url encoding process. However, in the compact serialization, instead of taking it as it is, the header value was mistakenly enclosed in quotation marks \r\n\r\n> \"eyJpc3MiOiJodHRwczovL2lzc3Vlci5leGFtcGxlIiwiY2xhaW1zIjpbImZhbWlseV9uYW1lIiwiZ2l2ZW5fbmFtZSIsImVtYWlsIiwiYWdlIl0sInR5cCI6IkpQVCIsImFsZyI6IkJCUy1YIn0\"\r\n\r\n and then base64url encoded again.\r\n\r\nAs a final step, I modified the \"fixtures_bbs-x.js\" file to handle the presentation protected header.\r\n",
       "createdAt": "2023-10-05T13:03:57Z",
-      "updatedAt": "2023-10-22T00:00:13Z",
+      "updatedAt": "2023-10-22T01:20:29Z",
       "baseRepository": "json-web-proofs/json-web-proofs",
       "baseRefName": "main",
       "baseRefOid": "d6ee024ba33d14cb173db6fc4176b7d00e4c5d8c",
@@ -5824,10 +5824,10 @@
         },
         {
           "author": "AlbertoSvg",
-          "authorAssociation": "NONE",
-          "body": "@dwaite @selfissued, thank you for the feedback, I'll review the updates and check if everything is okay as soon as possible. Given the upcoming deadline for IETF 118, I understand the urgency and I will try my best.\r\n\r\nI would also like to mention that I am concurrently working on a Rust library implementation of these drafts. \r\nIf by chance any of you have an interest in knowing more about it, please feel free to reach out.",
+          "authorAssociation": "CONTRIBUTOR",
+          "body": "@dwaite @selfissued, thank you for the feedback, I'll review the updates and check if everything is okay as soon as possible. Given the upcoming deadline for IETF 118, I understand the urgency and I will try my best.\r\n\r\nI would also like to mention that I am concurrently working on a Rust library implementation of these drafts. \r\nIf by chance any of you have an interest in knowing more about it, please feel free to reach out.\r\n\r\n\r\nEDIT: \r\nThis pull request has been closed since these changes were not anymore necessary. The updated changes can be found in the new pull request: [PR88](https://github.com/json-web-proofs/json-web-proofs/pull/88)",
           "createdAt": "2023-10-21T18:51:36Z",
-          "updatedAt": "2023-10-21T18:51:36Z"
+          "updatedAt": "2023-10-22T01:20:29Z"
         }
       ],
       "reviews": []
@@ -6209,6 +6209,69 @@
           "comments": []
         }
       ]
+    },
+    {
+      "number": 88,
+      "id": "PR_kwDOFsQObc5ddL1Q",
+      "title": "Fix Typo and Correct Object Attribute in BBS signature computation",
+      "url": "https://github.com/json-web-proofs/json-web-proofs/pull/88",
+      "state": "MERGED",
+      "author": "AlbertoSvg",
+      "authorAssociation": "CONTRIBUTOR",
+      "assignees": [],
+      "labels": [],
+      "body": "Hello,\r\nI have reviewed the updates, and everything looks good to me, except for two minor points that this PR addresses:\r\n\r\n1. Fixing a typo in the file `draft-ietf-jose-json-proof-algorithms.md`\r\n2. Fixing the BBS signature computation:\r\n\r\nIn the `bbs.fixtures.mjs` file, the BBS _sign_ function was called with an object containing a 'payloads' property. However, the _sign_ function is designed to accept input objects of type \"BbsSignRequest\", which require a 'messages' property. Providing an object with a 'payloads' property instead resulted in the 'messages' property being set to 'undefined'.\r\n\r\nNo issues were immediately visible because, the BBS scheme allows empty message arrays for signing operations. \r\nInternally, the 'sign' operation accessed the 'messages' property, which was \"undefined\". So basically, It successfully computed the signature over an empty array of messages.\r\n\r\nIf you test the current code as it is and pass to the function an empty array of payloads you will notice that it produces the same signature value. Additionally, if you set `verifySignature: true` in the _deriveProof_ function, the signature verification would fail, as the messages are correctly passed to the function in this case.\r\n",
+      "createdAt": "2023-10-22T01:16:21Z",
+      "updatedAt": "2023-10-22T02:17:37Z",
+      "baseRepository": "json-web-proofs/json-web-proofs",
+      "baseRefName": "main",
+      "baseRefOid": "d6ee024ba33d14cb173db6fc4176b7d00e4c5d8c",
+      "headRepository": "Cybersecurity-LINKS/json-web-proofs",
+      "headRefName": "main",
+      "headRefOid": "f17c15ba80420633a851dbd020ed2edf580a1548",
+      "closedAt": "2023-10-22T02:17:16Z",
+      "mergedAt": "2023-10-22T02:17:16Z",
+      "mergedBy": "dwaite",
+      "mergeCommit": {
+        "oid": "3c71d7af0096bd41c771ea008f578f58f675b738"
+      },
+      "comments": [
+        {
+          "author": "dwaite",
+          "authorAssociation": "CONTRIBUTOR",
+          "body": "Thank you Alberto! I look forward to seeing your rust implementation!",
+          "createdAt": "2023-10-22T02:17:37Z",
+          "updatedAt": "2023-10-22T02:17:37Z"
+        }
+      ],
+      "reviews": [
+        {
+          "id": "PRR_kwDOFsQObc5k0BC8",
+          "commit": {
+            "abbreviatedOid": "f17c15b"
+          },
+          "author": "dwaite",
+          "authorAssociation": "CONTRIBUTOR",
+          "state": "APPROVED",
+          "body": "",
+          "createdAt": "2023-10-22T02:08:55Z",
+          "updatedAt": "2023-10-22T02:08:55Z",
+          "comments": []
+        },
+        {
+          "id": "PRR_kwDOFsQObc5k0BEm",
+          "commit": {
+            "abbreviatedOid": "f17c15b"
+          },
+          "author": "selfissued",
+          "authorAssociation": "COLLABORATOR",
+          "state": "APPROVED",
+          "body": "",
+          "createdAt": "2023-10-22T02:10:47Z",
+          "updatedAt": "2023-10-22T02:10:47Z",
+          "comments": []
+        }
+      ]
     }
   ]
 }