Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding Usage Scenarios #25

Merged
merged 17 commits into from
Sep 10, 2024
Merged

Adding Usage Scenarios #25

merged 17 commits into from
Sep 10, 2024

Conversation

henkbirkholz
Copy link
Member

@henkbirkholz henkbirkholz commented Aug 28, 2024 •
edited by thomas-fossati
Loading

Fix #17

@henkbirkholz henkbirkholz requested a review from letmaik as a code owner August 28, 2024 12:31
thomas-fossati
thomas-fossati reviewed Aug 28, 2024
View reviewed changes
draft-birkholz-cose-tsa-tst-header-parameter.md Outdated
@@ -54,14 +57,35 @@ This document defines a CBOR Signing And Encrypted (COSE) header parameter for i
RFC 3161 {{-TSA}} provides a method to timestamp a message digest to prove that it was created before a given time.

This document defines a new CBOR Object Signing and Encryption (COSE) {{-COSE}} header parameter that carries the TimestampToken (TST) output of RFC 3161, thus allowing existing and widely deployed trust infrastructure to be used with COSE structures used for signing (COSE_Sign and COSE_Sign1).
To motivate the two different modes of use that are specified in this documents, two usage scenarios are illustrated in {{use-one}} and {{use-two}} below.
{{sec-timestamp-then-cose}} and {{sec-cose-then-timestamp}} then define the corresponding modes of use.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd split this into two and add the respective bits to the last line of the use case sections.

draft-birkholz-cose-tsa-tst-header-parameter.md Outdated Show resolved Hide resolved
draft-birkholz-cose-tsa-tst-header-parameter.md Outdated
To motivate the two different modes of use that are specified in this documents, two usage scenarios are illustrated in {{use-one}} and {{use-two}} below.
{{sec-timestamp-then-cose}} and {{sec-cose-then-timestamp}} then define the corresponding modes of use.

## Usage Scenario 1: A TST Included in Signed PDF Documents {#use-one}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ETITLETOOLONG :-D

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sarcasm aside, I will propose text.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

draft-birkholz-cose-tsa-tst-header-parameter.md Outdated

## Usage Scenario 1: A TST Included in Signed PDF Documents {#use-one}

In support of legal assurances, the quality of a signed PDF document can be improved by including a trustworthy signed timestamp.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"quality" doesn't sound like the right word

draft-birkholz-cose-tsa-tst-header-parameter.md Outdated
## Usage Scenario 1: A TST Included in Signed PDF Documents {#use-one}

In support of legal assurances, the quality of a signed PDF document can be improved by including a trustworthy signed timestamp.
In essence, a PDF signer wants to strengthen the assertion that a PDF was not signed before a certain point in time ("the signature cannot be older than").
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I find this a bit hard to digest.

You want to prove that "a certain document existed at a certain date" in a way that can't be disputed by a relying party.

draft-birkholz-cose-tsa-tst-header-parameter.md Outdated

This usage scenario motivates the "Timestamp then COSE" mode below.

## Usage Scenario 2: Registering a Signed Statement at a Transparency Service {#use-two}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

@thomas-fossati thomas-fossati mentioned this pull request Aug 28, 2024
Merged
@thomas-fossati
use cases reorg
5f4ddfd 
Signed-off-by: Thomas Fossati <[email protected]>
thomas-fossati
thomas-fossati approved these changes Sep 10, 2024
View reviewed changes
Copy link
Collaborator

@thomas-fossati thomas-fossati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

given enough guidance you can pass as an artist ;)

@thomas-fossati thomas-fossati merged commit 591f55d into main Sep 10, 2024
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomas-fossati thomas-fossati thomas-fossati approved these changes

@OR13 OR13 OR13 approved these changes

@letmaik letmaik Awaiting requested review from letmaik

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add use cases
3 participants
@henkbirkholz @OR13 @thomas-fossati