Fix checking composer version if the current user is root #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ping 😊 |
emepege
requested review from
jperera,
dortegau,
jmonterrubio,
sorobon,
blalop,
xtianae7,
MarioNv91 and
smartinsempere
emepege
approved these changes
Jun 7, 2023
jperera
approved these changes
Jun 7, 2023
blalop
approved these changes
Jun 14, 2023
xtianae7
approved these changes
Jun 14, 2023
|
Done @blalop! |
MarioNv91
approved these changes
May 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Calls
composer --versionwith-nparameterBenefits
Avoids hanging on if the role is executed as root. As it is not recommended, it's only done for checking the composer version, or if it is actually installed, so it should not pose a danger.
Possible Drawbacks
N/A
Applicable Issues
N/A