-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix use of TAO solution vector #28923
base: next
Are you sure you want to change the base?
Commits on Oct 23, 2024
-
Fix the way controllable parameters set and recieved from TAO.
We were changing the internal tao parameters vector and we should not have been doing that because it changed the way the tao optimization algorithms worked. We now have two parameter vectors, _parameters for TAO to take ownership of and another called _local_parameters that is still owned by OptimizeSolve. We can now update the _local_parameters with the data from TAO and compute our objective and gradient from this. This causes some poorly designed tests to diff and time out. These tests will be cleaned up in next set of commits.
Configuration menu - View commit details
-
Copy full SHA for ec48e51 - Browse repository at this point
Copy the full SHA ec48e51View commit details -
The change to the parameters vector will now correctly use the nelder…
… mead algorithm This test was diff'ing because it relied on the incorrect use of nelder mead to converge
Configuration menu - View commit details
-
Copy full SHA for 865b96d - Browse repository at this point
Copy the full SHA 865b96dView commit details -
Removed a 44 parameter nelder mead test. The optmization tolerance wa…
…s set extremely loose to make this solve solve in reasonable amount of time. This loose tolerance will result diffs in the solution. Nelder mead is not meant to be used with so many parameters. This problem is still being tested with gradient based methods
Configuration menu - View commit details
-
Copy full SHA for e485cad - Browse repository at this point
Copy the full SHA e485cadView commit details -
These tests were removed because it is now too difficult to hit these…
… PETSC errors after fixing the parameters vector. This test is optimizing a quadratic equation that converges in a single iteration. And with the fix to the parameters vector, the linesearch algorithms now work more robustly.
Configuration menu - View commit details
-
Copy full SHA for 9dbcd23 - Browse repository at this point
Copy the full SHA 9dbcd23View commit details -
This problem now converges faster and in fewer iterations which makes…
… the per iteration exodus output diff. The test and input files were also cleaned up
Configuration menu - View commit details
-
Copy full SHA for 6c6160a - Browse repository at this point
Copy the full SHA 6c6160aView commit details -
regolded files. With parameter fix they converge to the proper tolera…
…nce with slightly different optimized values than before. closes idaholab#28922
Configuration menu - View commit details
-
Copy full SHA for c36759e - Browse repository at this point
Copy the full SHA c36759eView commit details
Commits on Oct 24, 2024
-
Configuration menu - View commit details
-
Copy full SHA for b888c06 - Browse repository at this point
Copy the full SHA b888c06View commit details -
Configuration menu - View commit details
-
Copy full SHA for de31812 - Browse repository at this point
Copy the full SHA de31812View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1818e2f - Browse repository at this point
Copy the full SHA 1818e2fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8a12372 - Browse repository at this point
Copy the full SHA 8a12372View commit details -
Configuration menu - View commit details
-
Copy full SHA for e62b0fc - Browse repository at this point
Copy the full SHA e62b0fcView commit details