Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix use of TAO solution vector #28923

Open
wants to merge 11 commits into
base: next
Choose a base branch
from

Commits on Oct 23, 2024

  1. Fix the way controllable parameters set and recieved from TAO.

    We were changing the internal tao parameters vector and we should not have been
    doing that because it changed the way the tao optimization algorithms worked.
    
    We now have two parameter vectors, _parameters for TAO to take ownership of and
    another called _local_parameters that is still owned by OptimizeSolve.
    We can now update the _local_parameters with the data from TAO and compute our objective and gradient from this.
    
    This causes some poorly designed tests to diff and time out.
    These tests will be cleaned up in next set of commits.
    lynnmunday committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    ec48e51 View commit details
    Browse the repository at this point in the history
  2. The change to the parameters vector will now correctly use the nelder…

    … mead algorithm
    
    This test was diff'ing because it relied on the incorrect use of nelder mead to converge
    lynnmunday committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    865b96d View commit details
    Browse the repository at this point in the history
  3. Removed a 44 parameter nelder mead test. The optmization tolerance wa…

    …s set extremely loose to make this solve solve in reasonable amount of time. This loose tolerance will result diffs in the solution. Nelder mead is not meant to be used with so many parameters. This problem is still being tested with gradient based methods
    lynnmunday committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    e485cad View commit details
    Browse the repository at this point in the history
  4. These tests were removed because it is now too difficult to hit these…

    … PETSC errors after fixing the parameters vector. This test is optimizing a quadratic equation that converges in a single iteration. And with the fix to the parameters vector, the linesearch algorithms now work more robustly.
    lynnmunday committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    9dbcd23 View commit details
    Browse the repository at this point in the history
  5. This problem now converges faster and in fewer iterations which makes…

    … the per iteration exodus output diff. The test and input files were also cleaned up
    lynnmunday committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    6c6160a View commit details
    Browse the repository at this point in the history
  6. regolded files. With parameter fix they converge to the proper tolera…

    …nce with slightly different optimized values than before. closes idaholab#28922
    lynnmunday committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    c36759e View commit details
    Browse the repository at this point in the history

Commits on Oct 24, 2024

  1. Configuration menu
    Copy the full SHA
    b888c06 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    de31812 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    1818e2f View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    8a12372 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    e62b0fc View commit details
    Browse the repository at this point in the history