Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gaussian Probe optimization #28872

Draft
wants to merge 14 commits into
base: next
Choose a base branch
from
Draft

Gaussian Probe optimization #28872

wants to merge 14 commits into from

Conversation

maxnezdyur
Copy link
Contributor

closes #28871

@moosebuild
Copy link
Contributor

moosebuild commented Oct 17, 2024 •
edited
Loading

Job Documentation, step Docs: sync website on 6cba778 wanted to post the following:

View the site here

This comment will be updated on new commits.

@maxnezdyur maxnezdyur force-pushed the line_obj branch 2 times, most recently from 6628c4d to c5bc150 Compare October 17, 2024 19:19
@moosebuild
Copy link
Contributor

moosebuild commented Oct 17, 2024 •
edited
Loading

Job Coverage, step Generate coverage on 6cba778 wanted to post the following:

Framework coverage

b3924e #28872 6cba77
Total Total +/- New
Rate 85.05% 85.05% +0.00% 94.74%
Hits 106298 106334 +36 36
Misses 18691 18693 +2 2

Diff coverage report

Full coverage report

Modules coverage

Optimization

b3924e #28872 6cba77
Total Total +/- New
Rate 88.55% 88.65% +0.10% 96.55%
Hits 1972 2000 +28 28
Misses 255 256 +1 1

Diff coverage report

Full coverage report

Full coverage reports

Reports

This comment will be updated on new commits.

@maxnezdyur maxnezdyur marked this pull request as draft October 21, 2024 23:55
@moosebuild
Copy link
Contributor

Job Precheck, step Clang format on b1fad52 wanted to post the following:

Your code requires style changes.

A patch was auto generated and copied here
You can directly apply the patch by running, in the top level of your repository:

curl -s https://mooseframework.inl.gov/docs/PRs/28872/clang_format/style.patch | git apply -v

Alternatively, with your repository up to date and in the top level of your repository:

git clang-format b3924ece4ed556a7ca9811a6e046eb5c4503df72

@maxnezdyur maxnezdyur force-pushed the line_obj branch 4 times, most recently from f01337f to f07deef Compare October 22, 2024 12:21
lynnmunday
lynnmunday suggested changes Oct 22, 2024
View reviewed changes
Copy link
Contributor

@lynnmunday lynnmunday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lots of ternaries, very clever!

framework/doc/content/source/materials/ReporterOffsetFunctionMaterial.md Outdated Show resolved Hide resolved
framework/include/materials/ReporterOffsetFunctionMaterial.h Outdated Show resolved Hide resolved
framework/include/materials/ReporterOffsetFunctionMaterial.h Show resolved Hide resolved
framework/include/materials/ReporterOffsetFunctionMaterial.h Outdated Show resolved Hide resolved
modules/optimization/include/materials/MisfitReporterOffsetFunctionMaterial.h Outdated Show resolved Hide resolved
modules/optimization/src/materials/MisfitReporterOffsetFunctionMaterial.C Outdated Show resolved Hide resolved
modules/optimization/test/tests/optimizationreporter/function_misfit/forward_and_adjoint_side.i Outdated Show resolved Hide resolved
modules/optimization/test/tests/optimizationreporter/function_misfit/main_auto.i Outdated Show resolved Hide resolved
modules/optimization/test/tests/optimizationreporter/function_misfit/tests Outdated Show resolved Hide resolved
modules/optimization/test/tests/optimizationreporter/function_misfit/main_auto_side.i Show resolved Hide resolved
lynnmunday
lynnmunday reviewed Oct 23, 2024
View reviewed changes
framework/src/materials/ReporterOffsetFunctionMaterial.C
params.addParam<ReporterName>("point_name",
"reporter point name. This uses the reporter syntax "
"<reporter>/<name>.");
params.addParam<std::string>("property_name", "Material property base name");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

default or make required. required is kind of good because it is hard to know what it is named when we need to use it later in a postprocessor for the gradient.

@moosebuild
Copy link
Contributor

Job OpenMPI on 6cba778 : invalidated by @lynnmunday

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lynnmunday lynnmunday lynnmunday requested changes

@zachmprince zachmprince Awaiting requested review from zachmprince zachmprince is a code owner

@dschwen dschwen Awaiting requested review from dschwen dschwen is a code owner

@lindsayad lindsayad Awaiting requested review from lindsayad lindsayad is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Guassian probe type misfit for optimization
3 participants
@maxnezdyur @moosebuild @lynnmunday