Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Issue #164 - change access endpoint example #165

Closed
wants to merge 4 commits into from
Closed

Fix Issue #164 - change access endpoint example #165

wants to merge 4 commits into from

Conversation

johnbrvc
Copy link
Collaborator

@johnbrvc johnbrvc commented Nov 13, 2023 •
edited
Loading

One of the examples for the Access endpoint showed a capability of "patch_time". This capability does not appear in the Capabilities list that says "All capabilities are listed in the table below". Clearly, "patch_time" is not in the list. For clarity, it makes sense to change the example to use a documented property. "contest_start" makes the most sense here.
This fixes Issue #164

nickygerritsen and others added 4 commits July 10, 2023 21:20
@nickygerritsen @eldering
Drop -o a.out from example.
9a83fe9 
It is misleading that only one example has this and it's even the default.
@eldering
Release version 2023-06 of the CCS specifications.
ea4c1d6
@eldering
Ignore checking for access endpoint in the event feed for now.
a68aff5 
(cherry picked from commit ac9926d)
@johnbrvc
Fix Issue #164 - Access Example uses undocumented capability
20756be 
One of the examples for the Access endpoint showed a capability of "patch_time".  This capability does not appear in the Capabilities list that says "All capabilities are listed in the table below".  Clearly, "patch_time" is not in the list.  It makes sense to change the example to use a documented property and "contest_start" makes the most sense here.
@johnbrvc johnbrvc added the documentation Improvements or additions to documentation label Nov 13, 2023
@johnbrvc johnbrvc self-assigned this Nov 13, 2023
deboer-tim
deboer-tim requested changes Nov 14, 2023
View reviewed changes
Copy link
Member

@deboer-tim deboer-tim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would approve the contest_start change, but it looks like this branch also picked up several other commits that aren't listed in the description. If you can clean it up (or they get integrated separately) I will approve.

@johnbrvc
Copy link
Collaborator Author

I would approve the contest_start change, but it looks like this branch also picked up several other commits that aren't listed in the description. If you can clean it up (or they get integrated separately) I will approve.

Ugh. Yeah, I must have branched off of 2023-06. I'll fix that. Thanks.

@johnbrvc johnbrvc closed this Nov 14, 2023
@johnbrvc johnbrvc deleted the i164-Change-Access-endpoint-example branch November 14, 2023 14:28
@johnbrvc
Copy link
Collaborator Author

Apparently, this issue was already fixed in master (draft). Hence, I am closing this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deboer-tim deboer-tim deboer-tim requested changes

Assignees

@johnbrvc johnbrvc

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@johnbrvc @deboer-tim @nickygerritsen @eldering