-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tweak format and wording of contributor doc #566
Conversation
👈 Launch a binder notebook on this branch for commit 4791216 I will automatically update this comment whenever this PR is modified 👈 Launch a binder notebook on this branch for commit 23bd5c1 👈 Launch a binder notebook on this branch for commit 19e5a5b 👈 Launch a binder notebook on this branch for commit 59d4355 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## development #566 +/- ##
============================================
Coverage 65.37% 65.37%
============================================
Files 36 36
Lines 3038 3038
Branches 531 531
============================================
Hits 1986 1986
Misses 970 970
Partials 82 82 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
@@ -94,10 +102,10 @@ environment (from the home level of your local copy of the icepyx repo) with | |||
|
|||
mamba env create --name icepyx-env --channel conda-forge -f requirements-dev.txt -f requirements.txt |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any idea how easy it is to add the interactive "copy" button to the rendered version of this? Definitely not something we should hold up this PR for, but this caught my eye during review as a spot that would be nice to have.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that's a pretty easy change with a plugin: https://sphinx-copybutton.readthedocs.io/en/latest/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great - thanks Matt!
Split off from #565. Thank goodness for cherry-pick :)