This repository has been archived by the owner on Aug 13, 2024. It is now read-only.
feat: Introduce table config #148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liurenjie1024
requested review from
ZENOTME and
Xuanwo
and removed request for
ZENOTME
Xuanwo
reviewed
Aug 16, 2023
Xuanwo
approved these changes
Aug 16, 2023
ZENOTME
reviewed
Aug 17, 2023
| @@ -48,6 +51,7 @@ impl DataFileWriter { | |||
| arrow_schema: SchemaRef, | |||
| rows_divisor: usize, | |||
| target_file_size_in_bytes: u64, | |||
There was a problem hiding this comment.
Does these two parameter should also included in TableConfig
There was a problem hiding this comment.
Yeah, I think so.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #142.