Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GENIE] Add support for genie-icetray. #41

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Conversation

mjlarson
Copy link
Contributor

@mjlarson mjlarson commented Oct 2, 2024

Adds support for older genie-icetray simulation. Still needs tests added, but successfully reproduces the existing oneweight values in the files.

@mjlarson mjlarson marked this pull request as draft October 2, 2024 19:49
Copy link

github-actions bot commented Oct 2, 2024

Test Results

  6 files  ± 0    6 suites  ±0   3m 22s ⏱️ +37s
101 tests + 7   95 ✅ +1  0 💤 ±0   6 ❌ + 6 
606 runs  +42  569 ✅ +6  1 💤 ±0  36 ❌ +36 

For more details on these failures, see this check.

Results for commit c47a339. ± Comparison against base commit d4b29fa.

♻️ This comment has been updated with latest results.

@mjlarson
Copy link
Contributor Author

mjlarson commented Oct 4, 2024

Files needed for the tests are on cobalt-15:

  • /scratch/mlarson/simweights/src/examples/genie-icetray.140000A_000000.hdf
  • /scratch/mlarson/simweights/src/examples/genie-icetray.140000B_000000.hdf
  • /scratch/mlarson/simweights/src/examples/genie-icetray.140000C_000000.hdf
  • /scratch/mlarson/simweights/src/examples/genie-icetray.140000D_000000.hdf
  • /scratch/mlarson/simweights/src/examples/level2_genie-icetray.140000_000000.hdf

@mjlarson mjlarson marked this pull request as ready for review October 4, 2024 05:09
@kjmeagher
Copy link
Member

Thanks for doing this, can you please add the necessary input files to create the test files in contrib/book_simweights_testdata.py and then test with the output files?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants