[GENIE] Add support for genie-icetray. #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results 6 files ± 0 6 suites ±0 3m 22s ⏱️ +37s For more details on these failures, see this check. Results for commit c47a339. ± Comparison against base commit d4b29fa. ♻️ This comment has been updated with latest results. |
mjlarson
force-pushed
the
genie-icetray
branch
from
c3163f5
to
781f34a
Compare
for more information, see https://pre-commit.ci
|
Files needed for the tests are on cobalt-15:
|
…bviously indexable. Remove some temporary local variables.
for more information, see https://pre-commit.ci
|
Thanks for doing this, can you please add the necessary input files to create the test files in contrib/book_simweights_testdata.py and then test with the output files? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for older genie-icetray simulation. Still needs tests added, but successfully reproduces the existing oneweight values in the files.