add explanation what the effective livetime is #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #17 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 12 12
Lines 692 692
=========================================
Hits 692 692 ☔ View full report in Codecov by Sentry. |
|
This is great. I think it would be a good idea to also add a link to Michelangelo's report directly in the documentation |
|
I thought about that, but I was unsure since it is an internal document requiring a password. |
kjmeagher
approved these changes
Aug 23, 2023
|
Thanks @The-Ludwig, even though this code is public it has so many IceCube specific assumptions that I don't think there is a problem having the documentation link to a password protected internal report. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just compiled a bunch of information about the effective livetime for my thesis mainly from here.
I thought this might be easier for the next person before digging through the IC wiki. :)