Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Ruby 3.2 to CI. Fix standardrb errors. Update actions. #542

Closed
wants to merge 2 commits into from
Closed

Add Ruby 3.2 to CI. Fix standardrb errors. Update actions. #542

wants to merge 2 commits into from

Conversation

petergoldstein
Copy link

@petergoldstein petergoldstein commented May 31, 2023

Runs green on my fork.

@pboling
Copy link

pboling commented Mar 7, 2024

@pacso @petergoldstein Just tried this out locally, and I think because DST is within a few days from now it is currently exposing a phalanx of either bad code, or bad tests (legacy, I expect, in eitehr case). There are 11 failures, and the ones I looked closely at appeared to be unintentionally DST related (they were not tests intending to target DST functionality specifically, but failures were of the off-by-1-hour variety).

rspec ./spec/examples/daily_rule_spec.rb:70 # IceCube::DailyRule should update previous interval
rspec ./spec/examples/daily_rule_spec.rb:86 # IceCube::DailyRule should produce the correct days for @interval = 2
rspec ./spec/examples/occurrence_spec.rb:27 # IceCube::Occurrence to_s accepts a format option to comply with ActiveSupport
rspec ./spec/examples/schedule_spec.rb:364 # IceCube::Schedule next_occurrences should be able to calculate next occurrences ignoring excluded times
rspec ./spec/examples/to_yaml_spec.rb:47 # IceCube::Schedule to_yaml should be able to make a round-trip to YAML with .day
rspec ./spec/examples/to_yaml_spec.rb:80 # IceCube::Schedule to_yaml should be able to make a round-trip to YAML with .day_of_year
rspec ./spec/examples/to_yaml_spec.rb:92 # IceCube::Schedule to_yaml should be able to make a round-trip to YAML with .hour_of_day
rspec ./spec/examples/to_yaml_spec.rb:103 # IceCube::Schedule to_yaml should be able to make a round-trip to YAML with .minute_of_hour
rspec ./spec/examples/to_yaml_spec.rb:114 # IceCube::Schedule to_yaml should be able to make a round-trip to YAML with .month_of_year
rspec ./spec/examples/to_yaml_spec.rb:125 # IceCube::Schedule to_yaml should be able to make a round-trip to YAML with .second_of_minute
rspec ./spec/examples/to_yaml_spec.rb:136 # IceCube::Schedule to_yaml should be able to make a round-trip to YAML whilst preserving exception rules

I am using Ruby 3.2, and I got the same failures with Rails 7.0 as with Rails 7.1, so I don't think that's relevant.

Indeed... I get the same 11 failures on the master branch. DST cutover week is a ballin' time to work on scheduling code. 🏀

Also, if you are using gem in production (regardless of branch) - you may encounter some issues with the DST cutover.

@pacso
Copy link
Collaborator

pacso commented May 13, 2024

Was already implemented on #552

@pacso pacso closed this May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants