Support BYSETPOS for MONTHLY AND YEARLY freq #349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Interesting! This option doesn't seem to be clearly documented in the icalendar RFC but it looks like it's widely supported by different tools. I believe it would be worth finishing this up and adding it. |
nehresma
added a commit
to nehresma/ice_cube
that referenced
this pull request
Jul 30, 2018
A few small updates to Nicolas Marlier's BYSETPOS support added in PR ice-cube-ruby#349
joshbeckman
added a commit
to officeluv/ice_cube
that referenced
this pull request
Feb 5, 2019
In August 2016, @NicolasMarlier added BYSETPOS support (ice-cube-ruby#349). Then, in July 2018, @nehresma added a few small changes to run in modern Ruby and a more modern rspec (ice-cube-ruby#449). Then, in January 2019, @davidstosik and @k3rni suggested changes to reduce complexity. This incorporates all the above into a single diff.
davidstosik
pushed a commit
to davidstosik/ice_cube
that referenced
this pull request
Feb 6, 2019
A few small updates to Nicolas Marlier's BYSETPOS support added in PR ice-cube-ruby#349
nehresma
added a commit
to nehresma/ice_cube
that referenced
this pull request
Dec 12, 2022
A few small updates to Nicolas Marlier's BYSETPOS support added in PR ice-cube-ruby#349
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Self-explanatory ;)