addresses issue #41

icann-rdap-client/src/md/types.rs

@@ -232,6 +232,7 @@ pub(crate) fn events_to_table(
         let event_date = &event
             .event_date
             .to_owned()
+            .unwrap_or("????".to_string())
             .format_date_time(params)
             .unwrap_or_default();
         let mut ul: Vec<&String> = vec![event_date];

icann-rdap-common/src/check/items.rs

@@ -65,6 +65,12 @@ impl CheckItem {
     }
 
     // Events
+    pub fn event_date_is_absent() -> CheckItem {
+        CheckItem {
+            check_class: CheckClass::SpecificationError,
+            check: Check::EventDateIsAbsent,
+        }
+    }
     pub fn event_date_is_not_rfc3339() -> CheckItem {
         CheckItem {
             check_class: CheckClass::SpecificationError,

icann-rdap-common/src/check/mod.rs

@@ -171,6 +171,8 @@ pub enum Check {
     EmptyDomainVariant,
 
     // Events
+    #[strum(message = "event date is absent")]
+    EventDateIsAbsent,
     #[strum(message = "event date is not RFC 3339 compliant")]
     EventDateIsNotRfc3339,
 

icann-rdap-common/src/check/types.rs

@@ -208,11 +208,19 @@ impl GetSubChecks for ObjectCommon {
         // events
         if let Some(events) = &self.events {
             events.iter().for_each(|e| {
-                let date = DateTime::parse_from_rfc3339(&e.event_date);
-                if date.is_err() {
+                if let Some(date) = &e.event_date {
+                    let date = DateTime::parse_from_rfc3339(date);
+                    if date.is_err() {
+                        sub_checks.push(Checks {
+                            struct_name: "Events",
+                            items: vec![CheckItem::event_date_is_not_rfc3339()],
+                            sub_checks: Vec::new(),
+                        })
+                    }
+                } else {
                     sub_checks.push(Checks {
-                        struct_name: "Links",
-                        items: vec![CheckItem::event_date_is_not_rfc3339()],
+                        struct_name: "Events",
+                        items: vec![CheckItem::event_date_is_absent()],
                         sub_checks: Vec::new(),
                     })
                 }
@@ -265,7 +273,7 @@ mod tests {
         domain::Domain,
         entity::Entity,
         nameserver::Nameserver,
-        types::{Common, Extension, Link, ObjectCommon, StatusValue},
+        types::{Common, Event, Extension, Link, ObjectCommon, StatusValue},
         RdapResponse,
     };
 
@@ -547,6 +555,71 @@ mod tests {
             .expect("link missing check");
     }
 
+    #[test]
+    fn GIVEN_event_with_no_date_WHEN_checked_THEN_event_date_absent() {
+        // GIVEN
+        let rdap = RdapResponse::Domain(
+            Domain::builder()
+                .common(Common::builder().build())
+                .object_common(
+                    ObjectCommon::domain()
+                        .events(vec![Event::builder().event_action("foo").build()])
+                        .build(),
+                )
+                .build(),
+        );
+
+        // WHEN
+        let checks = rdap.get_checks(CheckParams {
+            do_subchecks: true,
+            root: &rdap,
+            parent_type: rdap.get_type(),
+        });
+
+        // THEN
+        checks
+            .sub("Events")
+            .expect("Events not found")
+            .items
+            .iter()
+            .find(|c| c.check == Check::EventDateIsAbsent)
+            .expect("event missing check");
+    }
+
+    #[test]
+    fn GIVEN_event_with_bad_date_WHEN_checked_THEN_event_date_is_not_date() {
+        // GIVEN
+        let rdap = RdapResponse::Domain(
+            Domain::builder()
+                .common(Common::builder().build())
+                .object_common(
+                    ObjectCommon::domain()
+                        .events(vec![Event::builder()
+                            .event_action("foo")
+                            .event_date("bar")
+                            .build()])
+                        .build(),
+                )
+                .build(),
+        );
+
+        // WHEN
+        let checks = rdap.get_checks(CheckParams {
+            do_subchecks: true,
+            root: &rdap,
+            parent_type: rdap.get_type(),
+        });
+
+        // THEN
+        checks
+            .sub("Events")
+            .expect("Events not found")
+            .items
+            .iter()
+            .find(|c| c.check == Check::EventDateIsNotRfc3339)
+            .expect("event missing check");
+    }
+
     #[test]
     fn GIVEN_nameserver_with_no_links_WHEN_checked_THEN_no_object_classes_should_have_self_link() {
         // GIVEN

icann-rdap-common/src/response/types.rs

@@ -124,8 +124,13 @@ pub struct Event {
     #[serde(skip_serializing_if = "Option::is_none")]
     pub event_actor: Option<String>,
 
+    /// This value is required by RFC 9083 (and 7483),
+    /// however some servers don't include it. Therefore
+    /// it is optional here to be compatible with these
+    /// types of non-compliant servers.
     #[serde(rename = "eventDate")]
-    pub event_date: String,
+    #[serde(skip_serializing_if = "Option::is_none")]
+    pub event_date: Option<String>,
 
     #[serde(skip_serializing_if = "Option::is_none")]
     pub links: Option<Links>,