Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented changes proposed in #39. Please note that this change breaks compatibility with previous version by removing (now redundant)
content_length
,content_type
andurl
fields here:icann-rdap/icann-rdap-client/src/lib.rs
Lines 33 to 35 in 8b8478c
Removed fields should now be accessible as part of a new
http_data
field onicann_rdap_client::RdapClientError::ParsingError
error variant (content_length
,content_type
andhost
fields respectively).Minimal reproducible example of a (now supported) use case:
Do let me know if any issues.