Issue617 refactor service with history 2 #652
Conversation
Working (although incomplete) twoday example
Update API and add example controller
There is global attribution at the project root
Use redis messages to generate results as they are requested, instead of the very time consuming approach of computing them on every step
Remove some unwanted Alfalfa isms
The exceptions are the min/max test, plus julia and javascript tests
|
Or yeah.. Like you said @javiarrobas, we could just explicitly enumerate them in a list. |
|
Huzzah! 🎉 Thank you @javiarrobas for continuing to try. One thing I'm curious about is still why it got stuck if there was a valid .fmu in that directory? Regarding the point of explicit list, we may think about if that list should be in any way accessible so anyone who wants to load in their own test case when running on their machine/setup can. But that goes back to my initial question, I wonder why it got stuck. |
That's because it was not a valid .fmu file but an empty folder called |
|
Ohh ok, I see! |
|
@javiarrobas @kbenne @EttoreZ I've addressed all Javier's comments (including a proposed readme convergence), Kyle's implemented updates from ADRENALIN, and Ettore's helped with updating some utility scripts to work with the new architecture. I think this PR is very very close to being ready to merge. Nothing more comes to my mind to be done at this point, except for a protection that was mentioned against what happened with Javier, but perhaps we save that for a specific issue on it's own as an enhancement? Can you all review/test a final time(s) and let me know any further comments or issues to be addressed? If you're ok with merging, please approve the github review. Note that I expect pending tests to pass. |
This is for #617 and #671 and in place of #622. It does everything from #622, but merges the Service architecture in a way to include the nrel/boptest-service git history.