Gh pages custom #637
Closed
Gh pages custom #637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If called multiple times, xxxx_dict_by_source used to increase even when the test case is not moving forward because it was calculated from xxxx_dict instead of using the _get_data_from_last_index method.
…tot. Notice that this does not affect to the xxxx_tot results.
…entation Closes ibpsa#555
Merging to staging branch
# Conflicts: # releasenotes.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@dhblum this addresses your first point in #606 (review). For the new section in the design guide, I'm doubting whether to implement it in this pull request or in the main one. If I implement it in this one then the main will have to pull the changes later on from the
gh-pages-custombranch. This stems from having part of the documentation inmain(onlydocs-design) and the rest in bothmainandgh-pages-custom, which I find a bit confusing right now. I suggest to unify both branches since it's not needed to keep a separate branch for gh-pages. We can always edit the web through regular pull requests tomaster. What do you think?