Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Origin149 fix start time examples2 #151

Merged
merged 5 commits into from
Sep 20, 2024

Conversation

javiarrobas
Copy link
Contributor

Fixes #149.

@javiarrobas javiarrobas self-assigned this Sep 20, 2024
@javiarrobas
Copy link
Contributor Author

@IamAniket12 FYI: I'm sorry but I had to revert the edits to have just one argument for start_time in the environment. The reason is that if we remove the random_start_time_variable, whenever we restart the episode here we assign a value to start_time which is thus not None anymore. This makes further resets of the environment not to find a random start time but always start by the same one.

@javiarrobas javiarrobas merged commit 9335d8c into master Sep 20, 2024
3 checks passed
@IamAniket12
Copy link
Contributor

@javiarrobas I believe we can manage this edge case in the script without explicitly passing the random_start_time variable. If you think it's a good idea, let me know and I'll give it a try.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix random_start_time in examples
2 participants