New state selection #1413
Open
New state selection #1413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e inverse annotation. For 1412. [ci skip]
For #1412. [ci skip]
Also, set nominal attribute for Medium.T as this is a state if mSenFac > 1. For #1412
This merges https://github.com/lbl-srg/modelica-buildings/tree/IBPSASync_issue1412_humidifer_u_Cvode_d_T_state 154682c039d2ad083bf24be095d934f633f1f2c6, and makes some further changes. For #1412. [ci skip]
This merges https://github.com/lbl-srg/modelica-buildings/tree/IBPSASync_issue1412_humidifer_u_Cvode_d_T_state 154682c039d2ad083bf24be095d934f633f1f2c6, and makes some further changes. For #1412. [ci skip]
|
@mwetter I see that this is assigned to me. Is this ready for review? |
|
@Mathadon : I just unassigned you. I like to do further analysis before merging this. |
Some models have higher number of nonlinear systems of equations. Likely due to different tearing, based on looking at Fluid.Examples.Performance.Example2. For #1412
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #1412