depr(snowflake): deprecate from_snowpark method

[deepyaman]

Since Ibis 9.2, it should be possible to use from_connection (introduced in #9603) as a more standardized alternative to from_snowpark. from_connection also supports a SnowflakeConnection instance.

[deepyaman]

@IndexSeek Do you foresee any issue with removing the from_snowpark method down the road?

[IndexSeek]

@IndexSeek Do you foresee any issue with removing the from_snowpark method down the road?

I don't see an issue with removing this. I am happy to see from_connection supports both snowflake.connector.SnowflakeConnection and snowflake.snowpark.Session for the Snowflake backend.

We may also want to adjust the references to from_snowpark in the Ibis - Now flying on Snowflake post to reflect this deprecation.

ibis/docs/posts/run-on-snowflake/index.qmd

Lines 41 to 42 in fdaeb5c

	The release of Ibis 9.0 includes the introduction of a new method,
	[`from_snowpark`](../../backends/snowflake.qmd#ibis.backends.snowflake.Backend.from_snowpark)

ibis/docs/posts/run-on-snowflake/index.qmd

Line 53 in fdaeb5c

con = ibis.snowflake.from_snowpark(session)

Thank you for keeping me in the loop on this one!

[deepyaman]

We may also want to adjust the references to from_snowpark in the Ibis - Now flying on Snowflake post to reflect this deprecation.

Makes sense; done!

[IndexSeek]

Thank you for updating that post! I think there is only one more place where from_snowpark is being used, in case we wanted to include the adjustment here too.

ibis/ibis/backends/snowflake/tests/test_udf.py

Line 241 in d3a2c0c

con = ibis.backends.snowflake.Backend.from_snowpark(session)

On another note, I used the ibis.snowflake.from_connection method today with both a Snowflake Python connection and a Snowpark session - it worked great in both cases!

[cpcloud]

experimental, straight to deprecated 😂

[cpcloud]

Merging, thanks @deepyaman and @IndexSeek!