Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Mobility Data Validator to 4.2.0 #1006

Merged
merged 1 commit into from
Jan 4, 2024
Merged

Upgrade Mobility Data Validator to 4.2.0 #1006

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,9 @@ tmp/
.tags
*.pid

# Ignore mobility data jar for building rules
*.jar
miles-grant-ibigroup marked this conversation as resolved.
Show resolved Hide resolved

# Optional npm cache directory
.npm

Expand Down
2 changes: 1 addition & 1 deletion lib/manager/components/validation/MobilityDataValidationResult.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@ const MobilityDataValidationResult = ({notice}) => {
<p><Markdown>{rule.description || ''}</Markdown></p>
<p>
<a
href={`https://gtfs-validator.mobilitydata.org/rules.html#${notice.code}`}
href={`https://gtfs-validator.mobilitydata.org/rules.html#${notice.code}-rule`}
miles-grant-ibigroup marked this conversation as resolved.
Show resolved Hide resolved
target='_blank'
rel='noreferrer'
>
Expand Down
2 changes: 1 addition & 1 deletion lib/manager/components/validation/rules.json
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
"cover-end-to-end": "cross-env COLLECT_COVERAGE=true npm run test-end-to-end",
"deploy": "mastarm deploy --minify --env production",
"flow": "mastarm flow",
"import-mobility-data": "wget https://github.com/MobilityData/gtfs-validator/releases/download/v4.1.0/gtfs-validator-4.1.0-cli.jar && java -jar gtfs-validator-4.1.0-cli.jar -n -o ./lib/manager/components/validation/ && rm ./lib/manager/components/validation/rules.json && mv ./lib/manager/components/validation/notice_schema.json ./lib/manager/components/validation/rules.json",
"import-mobility-data": "wget https://github.com/MobilityData/gtfs-validator/releases/download/v4.2.0/gtfs-validator-4.2.0-cli.jar && java -jar gtfs-validator-4.2.0-cli.jar -n -o ./lib/manager/components/validation/ && rm ./lib/manager/components/validation/rules.json && mv ./lib/manager/components/validation/notice_schema.json ./lib/manager/components/validation/rules.json",
"lint": "mastarm lint __tests__ lib scripts --quiet",
"lint-messages": "node scripts/lint-messages.js",
"postinstall": "patch-package && husky install",
Expand Down
Loading