optimize MC4WP_Form::get_subscriber_tags

ibericode · Sep 23, 2024 · 77af346 · 77af346
1 parent 00da115
commit 77af346
Showing 1 changed file with 9 additions and 15 deletions.
diff --git a/includes/forms/class-form.php b/includes/forms/class-form.php
@@ -760,20 +760,14 @@ public function get_message($key)
      */
     public function get_subscriber_tags()
     {
-        if (empty($this->settings['subscriber_tags'])) {
-            return array();
-        }
-
-        $tags = explode(',', $this->settings['subscriber_tags']);
-        $tags = array_map('trim', $tags);
-
-        // remove empty tag values
-        foreach ($tags as $i => $tag) {
-            if ($tag === '') {
-                unset($tags[ $i ]);
-            }
-        }
-
-        return array_values($tags);
+    	$tags = array();
+	    foreach (explode(',', $this->settings['subscriber_tags']) as $v) {
+	        $v = trim($v);
+	        if ($v == '') {
+	        	continue;
+	        }
+	        $tags[] = $v;
+	    }
+	    return $tags;
     }
 }