-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Export targets and make sure they can be used by other projects #177
Conversation
Co-authored-by: Andre Sailer <[email protected]>
Co-authored-by: Andre Sailer <[email protected]>
I made a few changes not to modify |
Any comments about this @andresailer @tmadlener ? It's less changes than #140 that has been open since 2021 and probably will require more work |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For me this looks good. Just for my understanding: Effectively this PR makes the builtin SIO install an SIOTargets.cmake, which then makes it possible for LCIO to simply find it via find_package
? Resp. it makes packages that depend on SIO (but maybe not LCIO) able to find SIO, even if it is builtin?
Co-authored-by: Andre Sailer <[email protected]>
When changing key4hep/k4geo#298 to use |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also works in my local build of the stack.
BEGINRELEASENOTES
ENDRELEASENOTES
This allows other programs to use the targets without having to rely on some variables that are set like LCIO_LIBRARIES and so on but it's backwards compatible (a clean up would be nice...). This will help with key4hep/k4geo#290 and iLCSoft/LCCD#7 that will have to be adapted based in this PR.