Bug: E2E test failure with new namespace #1615
Conversation
Signed-off-by: Angelina <[email protected]>
|
Thanks for raising this! |
|
|
||
| func Reset() { | ||
| config.RootConfigReset(setDefaults) | ||
| } |
There was a problem hiding this comment.
Make sure to check where this is being used as it is and failing the CI
There was a problem hiding this comment.
Do coreconfig.Reset() and Reset() mean the same this. I noticed the difference in syntax and was not certain if this was a separate function?
There was a problem hiding this comment.
yeah they are the same function. The other file is calling the Reset() that you just deleted in the coreconfig pkg
There was a problem hiding this comment.
Okay so I would need to remove them from there also correct?
There was a problem hiding this comment.
I removed them :). I did remove the additional calls to Reset that were made in additional files as well. I came across internal/events/event_manager_test.go and I noticed there is a line that reads "defer coreconfig.Reset()". I am wondering if the best step is to remove the "defer" keyword? I am still learning GO and from what I understand this word must follow a function or method call. If its not removed would I add this word before "mdi := &databasemocks.Plugin{}" ?
Proposed changes
Removed call to reset and ensured polling to up-to-date. This PR aims to correct issues with e2e failures when adding in namespaces.
Fixes # 1545
Types of changes
Please make sure to follow these points
< issue name >egAdded links in the documentation.Screenshots (If Applicable)
Other Information
Any message for the reviewer or kick off the discussion by explaining why you considered this particular solution, any alternatives etc.