Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup: Synchronizer is always present in protocol context #7791

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

fab-10
Copy link
Contributor

@fab-10 fab-10 commented Oct 21, 2024

PR description

Code cleanup PR, make synchronizer not optional in ProtocolContext since this is always the case on real world use cases, while it was optional only for the benefit of unit tests.

Fixed Issue(s)

Thanks for sending a pull request! Have you done the following?

  • Checked out our contribution guidelines?
  • Considered documentation and added the doc-change-required label to this PR if updates are required.
  • Considered the changelog and included an update if required.
  • For database changes (e.g. KeyValueSegmentIdentifier) considered compatibility and performed forwards and backwards compatibility tests

Locally, you can run these tests to catch failures early:

  • unit tests: ./gradlew build
  • acceptance tests: ./gradlew acceptanceTest
  • integration tests: ./gradlew integrationTest
  • reference tests: ./gradlew ethereum:referenceTests:referenceTests

@fab-10 fab-10 force-pushed the cleanup-synchronizer-protocol-context branch 2 times, most recently from c43be42 to 6f6ca09 Compare October 21, 2024 12:21
@fab-10 fab-10 force-pushed the cleanup-synchronizer-protocol-context branch from 6f6ca09 to f281b49 Compare October 21, 2024 12:48
@fab-10 fab-10 marked this pull request as ready for review October 21, 2024 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant