Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change requests to use flat encoding #7771

Open
wants to merge 30 commits into
base: main
Choose a base branch
from

Conversation

jframe
Copy link
Contributor

@jframe jframe commented Oct 15, 2024

PR description

Update generalised request encoding for changes introduced in devnet4

EIP-7251: change request to flat encoding ethereum/EIPs#8857
EIP-6110: change request to flat encoding ethereum/EIPs#8856
EIP-7002: change request to flat encoding ethereum/EIPs#8855
EIP-7685: change requests hash to flat hash ethereum/EIPs#8854
EIP-7685: group requests into request-data ethereum/EIPs#8924
Make execution requests a sidecar, take 2 ethereum/execution-apis#591

Fixed Issue(s)

#7744

Thanks for sending a pull request! Have you done the following?

  • Checked out our contribution guidelines?
  • Considered documentation and added the doc-change-required label to this PR if updates are required.
  • Considered the changelog and included an update if required.
  • For database changes (e.g. KeyValueSegmentIdentifier) considered compatibility and performed forwards and backwards compatibility tests

Locally, you can run these tests to catch failures early:

  • unit tests: ./gradlew build
  • acceptance tests: ./gradlew acceptanceTest
  • integration tests: ./gradlew integrationTest
  • reference tests: ./gradlew ethereum:referenceTests:referenceTests

@Gabriel-Trintinalia
Copy link
Contributor

I would love to have Request renamed to ExecutionRequest everywhere but can be done later

Signed-off-by: Jason Frame <[email protected]>
Signed-off-by: Jason Frame <[email protected]>
@jframe jframe marked this pull request as ready for review October 23, 2024 04:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants