FIX: bug in TrieKeyAdaptor swapLastByte #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swapLastByte did not take properly into account the last byte of a UInt256. Also, the UInt256 is reversed to littleEndian as part of the routine. More tests have been included for contract code chunking. Signed-off-by: Thomas Zamojski <[email protected]>
|
matkt
approved these changes
Nov 17, 2023
dragan2234
pushed a commit
to dragan2234/besu-verkle-trie
that referenced
this pull request
Jan 22, 2024
swapLastByte did not take properly into account the last byte of a UInt256. Also, the UInt256 is reversed to littleEndian as part of the routine. More tests have been included for contract code chunking. Signed-off-by: Thomas Zamojski <[email protected]> Signed-off-by: Dragan Pilipovic <[email protected]>
dragan2234
pushed a commit
to dragan2234/besu-verkle-trie
that referenced
this pull request
Jan 22, 2024
swapLastByte did not take properly into account the last byte of a UInt256. Also, the UInt256 is reversed to littleEndian as part of the routine. More tests have been included for contract code chunking. Signed-off-by: Thomas Zamojski <[email protected]> Signed-off-by: Dragan Pilipovic <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
There was a bug in TrieKeyAdaptor.swapLastByte : it did not take properly into account the last byte of a UInt256.
Some minor improvements where also made: