Revocable checks #64
Closed
Revocable checks #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whalelephant
force-pushed
the
revocable-checks
branch
from
bc7bc3e
to
5d2edb1
Compare
| @@ -73,6 +73,26 @@ impl RevocationStatusList { | |||
| self.revocation_list.get(idx).as_deref().copied() | |||
| } | |||
|
|
|||
| pub fn revoke(&mut self, idx: usize) -> Option<bool> { | |||
There was a problem hiding this comment.
Might be good to add some code doc when it returns true / false / none.
Comment on lines
+72
to
+81
| if let Some(at) = p2.requested_attributes.get_mut("attr4_referent") { | ||
| at.non_revoked = Some(NonRevocedInterval { | ||
| from: Some(10), | ||
| to: Some(20), | ||
| }) | ||
| } else { | ||
| panic!("Cannot add non_revoke to attri"); | ||
| } |
There was a problem hiding this comment.
I think we can just unwrap here
| pub max_cred_num: u32, | ||
| } | ||
|
|
||
| impl<'a> Mock<'a> { |
There was a problem hiding this comment.
I have never really done any intensive mocking with Rust, but would it not be easier to pull in a dependency for this? I have no issue with keeping this, but we might have a bit less code with a mock dependency.
Signed-off-by: bwty <[email protected]>
Signed-off-by: bwty <[email protected]>
Signed-off-by: bwty <[email protected]>
Signed-off-by: bwty <[email protected]>
Signed-off-by: bwty <[email protected]>
Signed-off-by: bwty <[email protected]>
whalelephant
force-pushed
the
revocable-checks
branch
from
2880b2f
to
f663deb
Compare
|
Addressed by #102 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #42 and updates e2e test framework