Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deal with snyk notifications for react-native -- by updating to latest of all dependencies #328

Merged
merged 5 commits into from
Feb 24, 2024

Conversation

swcurran
Copy link
Member

In making this PR, I looked up the latest versions of each of the called out in the Snyk report and used that. We'll see how that goes.

@swcurran
Copy link
Member Author

@berendsliedrecht — can you please review this PR. Please note that I didn’t run any tests on this — I just updated the three components in the two package.json files to their most recent versions per NPM. I did not verify that the updated dependencies won’t break anything. I know — bad way to do things, but I don’t really know how to run the react-native wrapper/example.

Thanks!

@berendsliedrecht
Copy link
Contributor

@swcurran could you delete the package-lock.json? It is created when running npm install, but we use pnpm only.

Signed-off-by: Stephen Curran <[email protected]>
@swcurran
Copy link
Member Author

Done — thanks!

@swcurran
Copy link
Member Author

@berendsliedrecht — bump -- looks like this is ready.

@swcurran swcurran merged commit 5794b25 into hyperledger:main Feb 24, 2024
26 checks passed
@swcurran
Copy link
Member Author

@andrewwhitehead — the post merge Lint task failed — https://github.com/hyperledger/anoncreds-rs/actions/runs/8031489343/job/21939863984. Could you please take a look and see what is to be done? Is it an issue or sunspots?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants