Extra validation for w3c credentials and presentations #325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrew Whitehead <[email protected]>
Signed-off-by: Andrew Whitehead <[email protected]>
swcurran
requested review from
TimoGlastra,
auer-martin,
berendsliedrecht and
Artemkaaas
TimoGlastra
approved these changes
Feb 9, 2024
| @@ -370,6 +370,24 @@ fn check_request_data( | |||
| )?; | |||
| } | |||
|
|
|||
| for (cred, proof) in presentation | |||
There was a problem hiding this comment.
Should these checks also be made when calling credential_process?
Otherwise looks good to me, thanks for picking this up
There was a problem hiding this comment.
Yes, there might be additional verification required for w3c credentials, I was only looking at presentations.
Artemkaaas
approved these changes
Feb 9, 2024
|
Questions for @TimoGlastra and @andrewwhitehead:
Lots of options -- what do you think is best? |
I think we can merge it as is and make improvements. The additions to the credential part do not impact security, but rather allow the holder to already catch an invalid credential.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #322