network.fabric: support FPC #207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Angelo De Caro <[email protected]>
|
I created a follow up PR #208 to allow TCC to extract the tokenRequest from args. |
mbrandenburger
requested changes
Mar 30, 2022
Comment on lines
344
to
360
| return chaincode.NewEndorseView( | ||
| namespace, | ||
| InvokeFunction, | ||
| ).WithNetwork( | ||
| n.n.Name(), | ||
| ).WithChannel( | ||
| n.ch.Name(), | ||
| ).WithSignerIdentity( | ||
| signer, | ||
| ).WithTransientEntry( | ||
| "token_request", requestRaw, | ||
| ).WithTxID( | ||
| fabric.TxID{ | ||
| Nonce: txID.Nonce, | ||
| Creator: txID.Creator, | ||
| }, | ||
| ).Endorse(context) |
There was a problem hiding this comment.
I believe you missed to remove the transient entry and pass the requestRaw as parameter :)
There was a problem hiding this comment.
good catch, fixed :)
Signed-off-by: Angelo De Caro <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the token chaincode is a FPC, then we must pass the token request as an input not via transient.
This, at least, until FPC supports transient: hyperledger/fabric-private-chaincode#666
Signed-off-by: Angelo De Caro [email protected]