fix(hydro_lang): avoid crashes and miscompilations with unused locations #1641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying hydroflow with
|
| Latest commit: |
90b32e0
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://61ac3a6f.hydroflow.pages.dev |
| Branch Preview URL: | https://pr1641.hydroflow.pages.dev |
Previously, if a location was not used in the graph, we would crash or use faulty IDs in the generated code. This also changes semantics slightly so that if there is a cluster with no assigned computation, it will be treated as an empty cluster at runtime (the list of cluster IDs will be an empty slice).
MingweiSamuel
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, if a location was not used in the graph, we would crash or use faulty IDs in the generated code. This also changes semantics slightly so that if there is a cluster with no assigned computation, it will be treated as an empty cluster at runtime (the list of cluster IDs will be an empty slice).