Add support for azure #1043
Add support for azure #1043
Conversation
|
For commit names use https://www.conventionalcommits.org/en/v1.0.0/ and for lints run |
|
For editing and rearrange old commits look into |
nickjiang2378
force-pushed
the
azure_support3
branch
from
dc439e6 to
bb47925
Compare
MingweiSamuel
force-pushed
the
azure_support3
branch
from
6c61ca5 to
b62ba82
Compare
hydro_deploy/core/src/azure.rs
Outdated
| }; | ||
|
|
||
| // #[derive(Debug)] | ||
| pub struct LaunchedComputeEngine { |
There was a problem hiding this comment.
Should probably be renamed to whatever Azure calls this (Compute Engine is a GCP term?). Also commented line above should be removed.
hydro_deploy/core/src/azure.rs
Outdated
|
|
||
| #[async_trait] | ||
| impl LaunchedSSHHost for LaunchedComputeEngine { | ||
| fn server_config(&self, bind_type: &ServerStrategy) -> ServerBindConfig { |
There was a problem hiding this comment.
This is nearly identical to GCP, so I wonder if we should move this into the trait and define a separate abstract function for getting the internal_ip.
hydro_deploy/core/src/azure.rs
Outdated
| self.user.as_str() | ||
| } | ||
|
|
||
| async fn open_ssh_session(&self) -> Result<AsyncSession<TcpStream>> { |
There was a problem hiding this comment.
Same here, this is identical to GCP so we should share the logic.
There was a problem hiding this comment.
I moved the launchedComputeEngine into a shared file
| os_type="linux", | ||
| machine_size="Standard_B1s", | ||
| region="East US", | ||
| image="", |
There was a problem hiding this comment.
If the image can indeed be omitted, we should make this an optional parameter.
There was a problem hiding this comment.
The azure image parameter is a little lengthy, so I made it optional for the user.
| deployment = hydro.Deployment() | ||
| localhost_machine = deployment.Localhost() | ||
|
|
||
| # gcp_vpc = hydro.GCPNetwork( |
| fn get_external_ip(&self) -> Option<String> { | ||
| self.external_ip.clone() | ||
| } | ||
| fn get_internal_ip(&self) -> String { |
| fn get_external_ip(&self) -> Option<String> { | ||
| self.external_ip.clone() | ||
| } | ||
| fn get_internal_ip(&self) -> String { |
…between gcp and azure
nickjiang2378
force-pushed
the
azure_support3
branch
from
ab1b338 to
7eb2e30
Compare
I accidentally committed some large files, so you won't see the commit history because I copied over the changes onto a fresh clone.
I accidentally committed some large files, so you won't see the commit history because I copied over the changes onto a fresh clone.