fix: cache pages to avoid system memory leak #400
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huynhsontung
changed the title
huynhsontung
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update: Memory leak is due to pages not unregistering the handler for view model's PropertyChanged events when navigating away. The ViewModel keeps a hard reference to the Page, so somehow both cannot be GC.
Looks like Pages don't get efficiently cleaned up when they are navigated away from. New Page instances are created on every navigation and never get properly released. It's confirmed to be a system-level memory leak. 🤦 Set
NavigationCacheModetoEnabledcan fix that.https://learn.microsoft.com/en-us/answers/questions/111194/memory-leak-on-uwp-with-target-versions-10-0-17763
microsoft/microsoft-ui-xaml#934
microsoft/microsoft-ui-xaml#3597