Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New lib for GPIO #99

Merged
merged 15 commits into from
Feb 1, 2024
Merged

New lib for GPIO #99

merged 15 commits into from
Feb 1, 2024

Conversation

rafal-gorecki
Copy link
Contributor

@rafal-gorecki rafal-gorecki commented Jan 25, 2024

bump::patch

  • new lib gpiod inside flash-firmware.py
  • Changelog fix
  • package.xml (no autor field in standard)
  • readme

@rafal-gorecki rafal-gorecki requested a review from delihus January 25, 2024 16:15
README.md Show resolved Hide resolved
rosbot/CHANGELOG.rst Outdated Show resolved Hide resolved
rosbot_utils/rosbot_utils/flash-firmware.py Outdated Show resolved Hide resolved
rosbot_utils/rosbot_utils/flash-firmware.py Outdated Show resolved Hide resolved
rosbot_utils/rosbot_utils/flash-firmware.py Outdated Show resolved Hide resolved
rosbot_utils/rosbot_utils/flash-firmware.py Outdated Show resolved Hide resolved
rosbot_utils/rosbot_utils/flash-firmware.py Outdated Show resolved Hide resolved
rosbot_utils/rosbot_utils/flash-firmware.py Outdated Show resolved Hide resolved
rosbot_utils/rosbot_utils/flash-firmware.py Outdated Show resolved Hide resolved
rosbot_utils/rosbot_utils/flash-firmware.py Outdated Show resolved Hide resolved
rosbot_utils/rosbot_utils/flash-firmware.py Outdated Show resolved Hide resolved
tools/Dockerfile.dev Outdated Show resolved Hide resolved
@rafal-gorecki rafal-gorecki requested a review from delihus January 30, 2024 11:35
Copy link
Contributor

@delihus delihus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the flashing instructions to the README and describe rosbot_utils package.

README.md Show resolved Hide resolved
tools/Dockerfile.dev Show resolved Hide resolved
@rafal-gorecki rafal-gorecki requested a review from delihus January 30, 2024 16:33
rosbot_utils/package.xml Show resolved Hide resolved
@delihus
Copy link
Contributor

delihus commented Jan 31, 2024

I flashed the robot and it worked great!

@rafal-gorecki rafal-gorecki requested a review from delihus January 31, 2024 12:11
rosbot_utils/package.xml Outdated Show resolved Hide resolved
rosbot_utils/package.xml Show resolved Hide resolved
@rafal-gorecki rafal-gorecki requested a review from delihus January 31, 2024 12:25
@DominikN
Copy link
Member

@delihus , @rafal-gorecki , have you confirmed it works also on ROSbot 2 PRO?

Copy link
Contributor

@delihus delihus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the ROSbot 2 PRO flashes for me it is all OK!

@delihus delihus self-requested a review February 1, 2024 07:07
@delihus
Copy link
Contributor

delihus commented Feb 1, 2024

Please update the description from gpiozero to gpiod

@rafal-gorecki
Copy link
Contributor Author

Now it's working also on 2 PRO in docker there need to be add
For 2R
device:

  • /dev/gpiochip0
  • /dev/ttyAMA0

For 2 PRO
device:

  • /dev/gpiochip4
  • /dev/ttyS4

@rafal-gorecki rafal-gorecki merged commit abec541 into humble Feb 1, 2024
3 checks passed
@rafal-gorecki rafal-gorecki deleted the flash-firmware-new-lib branch February 1, 2024 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants