Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add pre commit #75

Merged
merged 14 commits into from
Oct 24, 2023
Merged

Add pre commit #75

merged 14 commits into from
Oct 24, 2023

Conversation

delihus
Copy link
Contributor

@delihus delihus commented Oct 20, 2023 •
edited
Loading

bump::minor
Added:

  • check for merge conflicts
  • trim trailing whitespace
  • fix end of files
  • check yaml
  • check xml
  • check for added large files
  • check python ast
  • check json
  • python tests naming
  • codespell
  • Format YAML files
  • black
  • flake8
  • ament_lint_cmake
  • ament_copyright
  • doc8

@delihus
added scan test
473a6e2 
Signed-off-by: Jakub Delicat <[email protected]>
@delihus
Merge branch 'test-gazebo' into test-gazebo-scan
ab2c04c
@delihus
Configurated workspace
a704d14 
Signed-off-by: Jakub Delicat <[email protected]>
@delihus
Merge remote-tracking branch 'origin/humble' into code-extentions-rec…
f2cb857 
…ommendation
@delihus
added white spaces extention recommendation | added EOF new line setting
c278c06 
Signed-off-by: Jakub Delicat <[email protected]>
@delihus
added EOF new line
f2824c6 
Signed-off-by: Jakub Delicat <[email protected]>
@delihus
added EOF new line
7eb716d 
Signed-off-by: Jakub Delicat <[email protected]>
@delihus
Add and apply precommit hooks
d978d42 
Signed-off-by: Jakub Delicat <[email protected]>
@delihus
change line length to 99 for gh action
2a272bd 
Signed-off-by: Jakub Delicat <[email protected]>
@delihus delihus marked this pull request as draft October 20, 2023 12:55
@delihus delihus self-assigned this Oct 20, 2023
@delihus delihus marked this pull request as ready for review October 20, 2023 12:55
@delihus
fix black action
9a5946d 
Signed-off-by: Jakub Delicat <[email protected]>
@delihus
fix black action
00eb5d0 
Signed-off-by: Jakub Delicat <[email protected]>
@delihus
fixed importing
77df36c 
Signed-off-by: Jakub Delicat <[email protected]>
@delihus delihus requested a review from rafal-gorecki October 20, 2023 13:23
@delihus
added pre-commit to readme
c1043bd 
Signed-off-by: Jakub Delicat <[email protected]>
rafal-gorecki
rafal-gorecki approved these changes Oct 24, 2023
View reviewed changes
Copy link
Contributor

@rafal-gorecki rafal-gorecki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few minor remarks

.gitignore Show resolved Hide resolved
rosbot_bringup/launch/bringup.launch.py Outdated Show resolved Hide resolved
rosbot_gazebo/launch/simulation.launch.py Outdated Show resolved Hide resolved
@delihus delihus merged commit 20fec79 into humble Oct 24, 2023
3 checks passed
@delihus delihus deleted the add-pre-commit branch October 24, 2023 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rafal-gorecki rafal-gorecki rafal-gorecki approved these changes

Assignees

@delihus delihus

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@delihus @rafal-gorecki