6842 view px results #7388
Merged
6842 view px results #7388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
konzz
requested changes
Oct 21, 2024
| @@ -372,6 +373,8 @@ https://yourdomain,https://yourdomain | |||
| hubs,محاور | |||
| Hybrid,هجين | |||
| Icon,أيقونة | |||
| ID,ID | |||
| ID:,ID: | |||
There was a problem hiding this comment.
We probably only want ID once, remove the semi-colon wherever is been translated and add it outside the Translate tag.
| const templates = await templatesAPI.get(headers); | ||
| const [extractors, templates] = await Promise.all([ | ||
| extractorsAPI.get(), | ||
| templatesAPI.get(headers), |
There was a problem hiding this comment.
You can get the templates from the templates atom, no need for this request.
| <Translate>Templates meeting</Translate>{' '} | ||
| <Link to={linkPXTemplateCriteria} target="_blank"> | ||
| <span className="underline"> | ||
| <Translate>required criteria</Translate> |
There was a problem hiding this comment.
You can add classname to Translate like : <Translate className="underline">required criteria</Translate>
Also dividing a string in two might be problematic when translating
…6842-view-px-results
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #6842
PR checklist:
QA checklist: