Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove /api/entities/get_raw_page endpoint #7348

Merged
merged 1 commit into from
Oct 14, 2024

Conversation

Joao-vi
Copy link
Collaborator

@Joao-vi Joao-vi commented Oct 11, 2024

Changes

It was deleted the /api/entities/get_raw_page because is not used anymore in code base and also it was calling entites.getRawPage as data source, the problem is that getRawPage is not even declared on entities object.

I believe this feature was moved from /api/entities/get_raw_page to api/documents/page because the front-end code is still using getRawPage but pointing to api/documents/page

  async getRawPage(requestParams) {
    const response = await api.get(
      'documents/page',
      requestParams.add({ page: requestParams.data.page || 1 })
    );
    return response.json.data;
  },

@Joao-vi Joao-vi changed the base branch from development to production October 11, 2024 11:56
@Joao-vi Joao-vi marked this pull request as ready for review October 14, 2024 11:06
@Joao-vi Joao-vi requested a review from daneryl October 14, 2024 11:07
@daneryl daneryl merged commit 56bc4bb into production Oct 14, 2024
19 checks passed
@daneryl daneryl deleted the 6988/unused-api-endpoint branch October 14, 2024 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants