AT entity creation event listener fix

not using permissions commandContext anymore, the listener gets executed in the same context as the entity creation, we are only separating this into a event listener / use case to decouple v1 and v2 codes.
huridocs · Oct 19, 2024 · d9d0563 · d9d0563
1 parent de13916
commit d9d0563
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 17 deletions.
diff --git a/app/api/externalIntegrations.v2/automaticTranslation/RequestEntityTranslation.ts b/app/api/externalIntegrations.v2/automaticTranslation/RequestEntityTranslation.ts
@@ -46,15 +46,8 @@ export class RequestEntityTranslation {
 
   async execute(entityInputModel: EntityInputModel | unknown) {
     this.inputValidator.ensure(entityInputModel);
-    const atConfig = await this.ATConfigDS.get();
-    const atTemplateConfig = atConfig.templates.find(
-      t => t.template === entityInputModel.template?.toString()
-    );
-
-    const languageFrom = entityInputModel.language;
-    const languagesTo = atConfig.languages.filter(
-      language => language !== entityInputModel.language
-    );
+    const entity = Entity.fromInputModel(entityInputModel);
+    const { atTemplateConfig, languagesTo, atConfig, languageFrom } = await this.getConfig(entity);
 
     if (
       !atTemplateConfig ||
@@ -64,7 +57,6 @@ export class RequestEntityTranslation {
       return;
     }
 
-    const entity = Entity.fromInputModel(entityInputModel);
     let updatedEntities = (await this.entitiesDS.getByIds([entity.sharedId]).all()).filter(
       e => e.language !== languageFrom
     );
@@ -105,4 +97,15 @@ export class RequestEntityTranslation {
       })
     );
   }
+
+  private async getConfig(entity: Entity) {
+    const atConfig = await this.ATConfigDS.get();
+    const atTemplateConfig = atConfig.templates.find(
+      t => t.template === entity.template?.toString()
+    );
+
+    const languageFrom = entity.language;
+    const languagesTo = atConfig.languages.filter(language => language !== entity.language);
+    return { atTemplateConfig, languagesTo, atConfig, languageFrom };
+  }
 }
diff --git a/...externalIntegrations.v2/automaticTranslation/adapters/driving/ATEntityCreationListener.ts b/...externalIntegrations.v2/automaticTranslation/adapters/driving/ATEntityCreationListener.ts
@@ -1,8 +1,7 @@
+import { DefaultTransactionManager } from 'api/common.v2/database/data_source_defaults';
 import { EntityCreatedEvent } from 'api/entities/events/EntityCreatedEvent';
 import { EventsBus } from 'api/eventsbus';
-import { permissionsContext } from 'api/permissions/permissionsContext';
 import { AutomaticTranslationFactory } from '../../AutomaticTranslationFactory';
-import { DefaultTransactionManager } from 'api/common.v2/database/data_source_defaults';
 
 export class ATEntityCreationListener {
   private eventBus: EventsBus;
@@ -24,7 +23,6 @@ export class ATEntityCreationListener {
       ).get();
 
       if (active) {
-        permissionsContext.setCommandContext();
         const entityFrom = event.entities.find(e => e.language === event.targetLanguageKey) || {};
 
         entityFrom._id = entityFrom._id?.toString();

diff --git a/...egrations.v2/automaticTranslation/adapters/driving/specs/ATEntityCreationListener.spec.ts b/...egrations.v2/automaticTranslation/adapters/driving/specs/ATEntityCreationListener.spec.ts
@@ -88,10 +88,6 @@ describe('ATEntityCreationListener', () => {
       it('should execute RequestEntityTranslation on receiving entity creation event', async () => {
         expect(executeSpy).toHaveBeenCalledWith(entityEn);
       });
-
-      it('should execute RequestEntityTranslation with commandUser as its context user', async () => {
-        expect(userInContext).toBe(permissionsContext.commandUser);
-      });
     });
   });
 });