Fix At request translation when entity property has empty value (#7362)

huridocs · Oct 18, 2024 · 493e999 · 493e999
1 parent ba38e93
commit 493e999
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/app/api/entities.v2/model/Entity.ts b/app/api/entities.v2/model/Entity.ts
@@ -87,7 +87,7 @@ export class Entity {
     if (property.type === 'text' || property.type === 'markdown') {
       const isTitleProperty = property instanceof CommonProperty && property.name === 'title';
       if (isTitleProperty) return this.title;
-      return this.metadata[property.name][0].value as string;
+      return this.metadata[property.name]?.[0]?.value as string;
     }
 
     throw new Error('types other than string/markdown are not implemented yet');

diff --git a/app/api/externalIntegrations.v2/automaticTranslation/specs/RequestEntityTranslation.spec.ts b/app/api/externalIntegrations.v2/automaticTranslation/specs/RequestEntityTranslation.spec.ts
@@ -21,13 +21,15 @@ const fixtures: DBFixture = {
     factory.template('template1', [
       factory.property('text1'),
       factory.property('text2', 'markdown'),
+      factory.property('text3'),
       factory.property('empty_text'),
     ]),
   ],
   entities: [
     ...factory.entityInMultipleLanguages(['en', 'es', 'pt'], 'entity1', 'template1', {
       text1: [{ value: 'original text1' }],
       text2: [{ value: 'markdown text' }],
+      text3: [],
       empty_text: [{ value: '' }],
     }),
   ],
@@ -47,6 +49,7 @@ const fixtures: DBFixture = {
               properties: [
                 factory.idString('text1'),
                 factory.idString('text2'),
+                factory.idString('text3'),
                 factory.idString('empty_text'),
               ],
               commonProperties: [factory.commonPropertiesTitleId('template1')],