upgrade rollup #101
Merged
upgrade rollup #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This uses `@rollup/plugin-terser` instead of `rollup-plugin-babel` which is deprecated/unmaintained and contains security warnings. Because these are two different minifiers, the output is slightly different (terser is, well, _more terse_), but I've configured it so it's reasonably close to the old minified distfile. I was only able to get to `rollup` v3.x; `rollup` v4.x requires Node.js v18.x. We can upgrade to v4.x once we decide to drop Node.js v16.x support.
boneskull
force-pushed
the
boneskull/rollup-upgrade
branch
2 times, most recently
from
8640f4f to
0a42471
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses
@rollup/plugin-terserinstead ofrollup-plugin-babelwhich is deprecated/unmaintained and contains security warnings.Because these are two different minifiers, the output is slightly different (terser is, well, more terse), but I've configured it so it's reasonably close to the old minified distfile.
I was only able to get to
rollupv3.x;rollupv4.x requires Node.js v18.x. We can upgrade to v4.x once we decide to drop Node.js v16.x support.Screenshot of the diff between the new (left) and old (right):
The non-minified output is the same except that the new one omits
Object.defineProperty(exports, '__esModule', { value: true })from the output. This change looks like it comes out of Rollup v3 itself.