Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add $ to the end of filename regex patterns #931

Merged
merged 1 commit into from
Oct 9, 2024

Conversation

tomaarsen
Copy link
Member

What does this PR do?

  • Add $ to the end of filename regex patterns
  • add an unrelated test for a model with modeling files in a subfolder and configuration files in the root. This passes on main, but failed on 1.19.0. As expected, if subfolder="openvino", then the OV files can be seen, if subfolder="", then they are not.

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?

  • Tom Aarsen

And add an unrelated test for a model with modeling files in a subfolder and configuration files in the root. This passes on main, but failed on 1.19.0
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Collaborator

@echarlaix echarlaix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good thanks @tomaarsen !

@echarlaix echarlaix merged commit cb5208c into huggingface:main Oct 9, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants