Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for Mixtral G1 pytest failures #1652

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

12010486
Copy link
Contributor

What does this PR do?

Fixes for the following pytests on Gaudi1:

MixtralModelTest::test_contrastive_generate
MixtralModelTest::test_contrastive_generate_dynamic_shapes
MixtralModelTest::test_contrastive_generate_low_memory
MixtralModelTest::test_determinism
MixtralModelTest::test_feed_forward_chunking
MixtralModelTest::test_generate_from_inputs_embeds_decoder_only
MixtralModelTest::test_generate_without_input_ids
MixtralModelTest::test_greedy_generate
MixtralModelTest::test_left_padding_compatibility
MixtralModelTest::test_load_balancing_loss
MixtralModelTest::test_sample_generate
MixtralModelTest::test_save_load MixtralModelTest::test_resize_embeddings_untied

Modified the optimum/habana/utils.py
Included Gaudi3 in get_device_name()

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?

Tested on G1/G2/G3

@12010486 12010486 requested a review from regisss as a code owner December 20, 2024 16:43
@12010486
Copy link
Contributor Author

@libinta, @imangohari1, if you want to have a look

@regisss
Copy link
Collaborator

regisss commented Dec 23, 2024

@12010486 Is this PR different from #1654 ?

@12010486
Copy link
Contributor Author

No, it is basically the same, except for make style that here is included. However, I have not received confirmation yet on which PR to keep

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants