Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SW-207965] Add batch splitting in attention layer to hide NIC latency(#14) #1640

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

[SW-207965] Add batch splitting in attention layer to hide NIC latency(#14) #1640

wants to merge 3 commits into from

Conversation

kalyank007
Copy link 

- Introduced the `--attn_batch_split` parameter to enable batch splitting in the attention and mlp layer.
- This approach aims to overlap communication and computation, effectively hiding NIC latency during distributed attention operations.

- Perform the add in the beginning of the next layer for better pipelining

- Updated Readme

- [SW-212702] Fix the  attn_batch_split argument specific to llama config (#74)

@kalyank007 @kalyanjkk
[SW-207965] Add batch splitting in attention layer to hide NIC latency (
9361434 
huggingface#14)

    - Introduced the `--attn_batch_split` parameter to enable batch
    splitting in the attention and mlp layer.
    - This approach aims to overlap communication and computation,
    effectively hiding NIC latency during distributed attention operations.

    - Perform the add in the beginning of the next layer for better pipelining

    - Updated Readme

    - [SW-212702] Fix the  attn_batch_split argument specific to llama config (huggingface#74)

Co-authored-by: Kalyan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ssarkar2 ssarkar2 ssarkar2 left review comments

@mgonchar mgonchar mgonchar left review comments

@bhargaveede bhargaveede Awaiting requested review from bhargaveede bhargaveede is a code owner

@vivekgoe vivekgoe Awaiting requested review from vivekgoe vivekgoe is a code owner

@mandy-li mandy-li Awaiting requested review from mandy-li mandy-li is a code owner

@libinta libinta Awaiting requested review from libinta libinta is a code owner

@regisss regisss Awaiting requested review from regisss regisss is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
synapse1.20
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kalyank007 @mgonchar @ssarkar2 @libinta